Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISSUE #12 feat: add Fan Poll Auth checking and temporary login.html page #28

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

ISSUE #12 feat: add Fan Poll Auth checking and temporary login.html page #28

wants to merge 2 commits into from

Conversation

SilverDragonOfR
Copy link
Contributor

@SilverDragonOfR SilverDragonOfR commented Oct 11, 2023 •
edited
Loading

Added a @login_required decorator to check whether user is logged in or not.
If not then, they are redirected to a temporary login.html
Issue #12

@SilverDragonOfR SilverDragonOfR mentioned this pull request Oct 11, 2023
Open
@SilverDragonOfR SilverDragonOfR changed the title ISSUE #4 feat: add Fan Poll Auth checking and temporary login.html page ISSUE #12 feat: add Fan Poll Auth checking and temporary login.html page Oct 11, 2023
NSmonish
NSmonish requested changes Oct 12, 2023
View reviewed changes
Copy link
Collaborator

@NSmonish NSmonish left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Login is not accessible and there should be a form to receive and store login and sign up credentials

@SilverDragonOfR
Copy link
Contributor Author

SilverDragonOfR commented Oct 12, 2023 •
edited
Loading

@NSmonish
I have only solved ISSUE #12 by directing users to login page.
I have not done ISSUE #1. So the login.html is empty for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NSmonish NSmonish Awaiting requested review from NSmonish

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SilverDragonOfR @NSmonish